Ensure directories are writable when generating reports from read-only sources #6358
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we make the folders read-only in CI? |
I added a test case, but I am sure, that you could make that a bit nicer than me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When copying files while generating reports, make newly created directories writeable.
Motivation and Context
As reported in #6357 some distributions of JMeter provide the template directories read-only, only. As that is probably a good idea, we should support those kind of setups.
How Has This Been Tested?
Made some directories in ./bin/report-templates read-only and generated a report. With the current released version of JMeter we will get an exception as described in #6357. With the fix, the report is generated without problems.
Screenshots (if appropriate):
Types of changes
Checklist: