OAK-11085: Use a single definition of MAX_SEGMENT_SIZE in Segment #1702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where
MAX_SEGMENT_SIZE
was defined in bothSegment
andSegmentDataUtils
with the same value, leading to redundancy. To resolve this:MAX_SEGMENT_SIZE
inSegment.java
has been madepublic
.SegmentDataUtils.java
, the static importimport static org.apache.jackrabbit.oak.segment.Segment.MAX_SEGMENT_SIZE;
was added to utilize the constant defined inSegment.java
.MAX_SEGMENT_SIZE
inSegmentDataUtils
has been removed.Motivation
Having the constant defined in two places created potential maintenance issues and inconsistency risks. By consolidating the definition in
Segment.java
, the code becomes cleaner, more maintainable, and reduces the possibility of errors in future updates.Impact
Please review and merge this PR to streamline the constant usage in both classes.