OAK-11085: Use a single definition of MAX_SEGMENT_SIZE in Segment #1702
Conversation
- Changed MAX_SEGMENT_SIZE in Segment.java to be public. - Updated SegmentDataUtils.java to use the MAX_SEGMENT_SIZE from Segment by importing it statically. - Removed the redundant definition of MAX_SEGMENT_SIZE in SegmentDataUtils to avoid duplication.
|
I successfully ran clean install and clean install -PintegrationTesting with all tests passing |
JeonDaehong
changed the title
|
Hey @JeonDaehong, thank you for your PR! Sorry, I should have made it clear on the Jira issue, but I’ve already created a PR for this task: |
|
It's very unfortunate... It was my first PR, so I really wanted to be a part of it. Is there perhaps another good opportunity...? |
|
I’m only contributing occasionally to this project so I don’t have a good overview of tasks that could be interesting to solve, but maybe Jira gives you some ideas. Thanks for your interest in this project! |
|
Thank you for kindly explaining. Thanks to this issue, I was able to take my first step in contributing to open source. I will continue to show interest and contribute more in the future. I followed you because I want to learn a lot from you in the future. Thank you! Have a great day! |
Description
This PR addresses an issue where
MAX_SEGMENT_SIZEwas defined in bothSegmentandSegmentDataUtilswith the same value, leading to redundancy. To resolve this:MAX_SEGMENT_SIZEinSegment.javahas been madepublic.SegmentDataUtils.java, the static importimport static org.apache.jackrabbit.oak.segment.Segment.MAX_SEGMENT_SIZE;was added to utilize the constant defined inSegment.java.MAX_SEGMENT_SIZEinSegmentDataUtilshas been removed.Motivation
Having the constant defined in two places created potential maintenance issues and inconsistency risks. By consolidating the definition in
Segment.java, the code becomes cleaner, more maintainable, and reduces the possibility of errors in future updates.Impact
Please review and merge this PR to streamline the constant usage in both classes.