Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11039: Flaky MissingLastRevSeekerTest with RDB #1655

Closed
wants to merge 3 commits into from
Closed

OAK-11039: Flaky MissingLastRevSeekerTest with RDB #1655

wants to merge 3 commits into from

Conversation

sii74826
Copy link

No description provided.

reschke
reschke reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to actually find the root cause; there seems to be another test that breaks the test contract for RDB DocumentStore tests.

@sii74826
Copy link
Author

I fully agree, but for now we need to apply a workaround (similar to OAK-11019 ) to recover pipelines that have been failing for several weeks.
If we want to merge it, could you please merge it (with squash option)? No permissions.

Joscorbe
Joscorbe approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@Joscorbe Joscorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should find the root cause and fix it, but could we merge this temporarily to unblock the pipeline meanwhile? @reschke

I would vote to merge this, but with the aim of fixing it properly in future

@reschke reschke changed the title Oak 11039 OAK-11039: Flaky MissingLastRevSeekerTest with RDB Sep 5, 2024
reschke
reschke requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this has been overtaken by events; see OAK-11113.

@sii74826 sii74826 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reschke reschke reschke requested changes

@stefan-egli stefan-egli stefan-egli approved these changes

@Joscorbe Joscorbe Joscorbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sii74826 @reschke @Joscorbe @stefan-egli