[OAK-10953] #1646
[OAK-10953] #1646
Conversation
.../src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java
Outdated
Show resolved
Hide resolved
alagodasii
force-pushed
the
OAK-10953
branch
3 times, most recently
from
caf2331
to
870f64c
Compare
…ch knn search feature
| String propertyPath = PathUtils.getParentPath(pd.name); | ||
| String propertyName = PathUtils.getName(pd.name); | ||
| NodeState tempState = targetNodeState; | ||
| for (String token : PathUtils.elements(propertyPath)) { |
There was a problem hiding this comment.
Could breaking on an empty token break anything? Does it always leave tempState in a desirable state?
There was a problem hiding this comment.
It's hard to tell myself. This part existed in the previous implementation.
There was a problem hiding this comment.
Good job! Just a minor.
The failing test in oak-search-elastic is not related to this changes. It's a flaky test we should look at separately.
...rc/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java
Outdated
Show resolved
Hide resolved
Thanks for confirmation. I observed no problem with it on the local environment, so that was my guess. I'll have a look at it closer, because otherwise we might easily forget about it. |
Substitute Elastiknn plugin with native inn query provided by Elasticsearch.