Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator #1409

Open
wants to merge 2 commits into
base: DetailedGC/OAK-10199
Choose a base branch
from

Conversation

Joscorbe
Copy link
Member

@Joscorbe Joscorbe commented Apr 8, 2024

This is just a proposal to solve https://issues.apache.org/jira/browse/OAK-10758

Another proposal PR is coming, that improves exception handling to avoid crashing when this exception is thrown.

@Joscorbe Joscorbe changed the base branch from trunk to DetailedGC/OAK-10199 April 8, 2024 16:18
@Joscorbe Joscorbe changed the title OAK-10758: Proposal: Add system property to control noCursorTimeout OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator Apr 8, 2024
Copy link
Contributor

@stefan-egli stefan-egli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about only calling noCursorTimeout() if it is set to true ? (would leave things unchanged if this property is not set or set to false)

PS: as per docu there could still be a MongoCursorNotFoundException thrown if the session times out (eg after 30min). I.e. if the problem persists even with noCursorTimeout=true we might have to shrink the batch size (or introduce explicit refreshSessions calls)

or put differently : a smaller batch size could also be something to look into in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants