OAK-6772: Convert oak-solr-core to OSGi R7 annotations #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored property default values.
Removed redundant type conversions. Replaced component properties with configuration type methods. Fixed property names.
kwin
reviewed
Nov 7, 2024
| collapseJcrContentNodes = Boolean.valueOf(String.valueOf(componentContext.getProperties().get(COLLAPSE_JCR_CONTENT_NODES))); | ||
| collapseJcrContentParents = Boolean.valueOf(String.valueOf(componentContext.getProperties().get(COLLAPSE_JCR_CONTENT_PARENTS))); | ||
| protected void activate(Configuration configuration) { | ||
| pathChildrenFieldName = configuration.path_child_field(); |
There was a problem hiding this comment.
I would remove this indirection, just store the object
There was a problem hiding this comment.
Imho hat would need a new Jira issue.
| String solr_conf_dir() default SolrServerConfigurationDefaults.CONFIGURATION_DIRECTORY; | ||
|
|
||
| String name() default "remote"; | ||
| } | ||
|
|
||
| private String solrHttpUrl; |
There was a problem hiding this comment.
I would remove all fields except for remoteSolrServerConfiguration
There was a problem hiding this comment.
That is also not in the scope of OAK-6772, is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.