Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: there is no errors when sql is incorrect #123

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

LinuxSuRen
Copy link
Contributor

fix #122

@LinuxSuRen
Copy link
Contributor Author

hi @shuwenwei , my tool formatted some code lines automatically. Please let me know if you think it's not acceptable. And thanks for your time.

@shuwenwei
Copy link
Contributor

hi @shuwenwei , my tool formatted some code lines automatically. Please let me know if you think it's not acceptable. And thanks for your time.

I think it is ok.

@JackieTien97 JackieTien97 merged commit 553bcc5 into apache:main Mar 28, 2025
6 checks passed
@JackieTien97
Copy link
Contributor

@LinuxSuRen please cp it to dev/1.3

@LinuxSuRen LinuxSuRen deleted the fix/no-errs branch March 28, 2025 05:39
@LinuxSuRen
Copy link
Contributor Author

@LinuxSuRen please cp it to dev/1.3

I didn't get your point. Could you tell more?

@shuwenwei
Copy link
Contributor

shuwenwei commented Mar 31, 2025

@LinuxSuRen please cp it to dev/1.3

I didn't get your point. Could you tell more?

cherry pick this commit to dev/1.3 branch and create another PR whose target branch is dev/1.3
截屏2025-03-31 10 46 56

@LinuxSuRen
Copy link
Contributor Author

So, if contributors should not create a PR against the main branch?

I'm wondering if it's possible to set dev/x.x as the default branch. For example, for now set the default branch to be `dev/1.3.

@shuwenwei
Copy link
Contributor

So, if contributors should not create a PR against the main branch?

I'm wondering if it's possible to set dev/x.x as the default branch. For example, for now set the default branch to be `dev/1.3.

The main branch can be considered 2.0, but dev/1.3 branch is also being maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Without any error return even I give it an invalid sql
3 participants