Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:Expose some keepalive-related configuration for Druid, Hikari, and DBCP #7130

Open
wants to merge 7 commits into
base: 2.x
Choose a base branch
from

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Jan 23, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Expose some keepalive-related configuration for Druid, Hikari, and DBCP to allow users to customize database connection pool settings.

Ⅱ. Does this pull request fix one issue?

Fixes #6600

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes missing coverage. Please review.

Project coverage is 52.98%. Comparing base (0c361b7) to head (222be90).

Files with missing lines Patch % Lines
...igure/properties/server/store/DruidProperties.java 50.00% 11 Missing ⚠️
...figure/properties/server/store/DbcpProperties.java 50.00% 9 Missing ⚠️
...gure/properties/server/store/HikariProperties.java 50.00% 9 Missing ⚠️
...e/seata/server/store/HikariDataSourceProvider.java 55.55% 0 Missing and 4 partials ⚠️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% 3 Missing ⚠️
...che/seata/server/store/DbcpDataSourceProvider.java 75.00% 0 Missing and 2 partials ⚠️
...he/seata/server/store/DruidDataSourceProvider.java 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7130      +/-   ##
============================================
- Coverage     52.99%   52.98%   -0.01%     
- Complexity     6822     6838      +16     
============================================
  Files          1145     1148       +3     
  Lines         40559    40641      +82     
  Branches       4737     4745       +8     
============================================
+ Hits          21494    21534      +40     
- Misses        17017    17050      +33     
- Partials       2048     2057       +9     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
...che/seata/server/store/DbcpDataSourceProvider.java 92.00% <75.00%> (-8.00%) ⬇️
...he/seata/server/store/DruidDataSourceProvider.java 92.85% <80.00%> (-7.15%) ⬇️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
...e/seata/server/store/HikariDataSourceProvider.java 87.87% <55.55%> (-12.13%) ⬇️
...figure/properties/server/store/DbcpProperties.java 50.00% <50.00%> (ø)
...gure/properties/server/store/HikariProperties.java 50.00% <50.00%> (ø)
...igure/properties/server/store/DruidProperties.java 50.00% <50.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

druid连接池配置参数放开test-on-borrow
1 participant