feature: support openGuass and GuassDB in AT mode #6020

liuqiufeng · 2023-11-11T12:03:04Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

support openGuass and GuassDB
支持openGuass 和 GuassDB

Ⅱ. Does this pull request fix one issue?

fixes #5740

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov · 2023-11-27T02:10:14Z

Codecov Report

Merging #6020 (6ba3ac5) into 2.x (9e5abc2) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6020      +/-   ##
============================================
- Coverage     49.45%   49.30%   -0.15%     
+ Complexity     4811     4795      -16     
============================================
  Files           913      928      +15     
  Lines         31678    31735      +57     
  Branches       3826     3838      +12     
============================================
- Hits          15665    15648      -17     
- Misses        14474    14546      +72     
- Partials       1539     1541       +2

Files	Coverage Δ
...n/src/main/java/io/seata/common/util/PageUtil.java	`55.17% <ø> (ø)`
...ta/core/store/db/sql/lock/GaussDBLockStoreSql.java	`0.00% <0.00%> (ø)`
...ata/core/store/db/sql/log/GaussDBLogStoreSqls.java	`0.00% <0.00%> (ø)`
...urce/sql/handler/gaussdb/GaussDBEscapeHandler.java	`0.00% <0.00%> (ø)`
...source/sql/struct/cache/GaussDBTableMetaCache.java	`0.00% <0.00%> (ø)`
...datasource/undo/gaussdb/GaussDBUndoLogManager.java	`0.00% <0.00%> (ø)`
...in/java/io/seata/sqlparser/util/JdbcConstants.java	`0.00% <0.00%> (ø)`
.../src/main/java/io/seata/core/constants/DBType.java	`0.00% <0.00%> (ø)`
...datasource/exec/gaussdb/GaussDBInsertExecutor.java	`0.00% <0.00%> (ø)`
...source/undo/gaussdb/GaussDBUndoDeleteExecutor.java	`0.00% <0.00%> (ø)`
... and 8 more

... and 8 files with indirect coverage changes

script/server/db/postgresql.sql

funky-eyes

LGTM

slievrly · 2023-12-06T03:52:41Z

dependencies/pom.xml

@@ -221,6 +222,11 @@
                <artifactId>DmJdbcDriver18</artifactId>
                <version>${dm.version}</version>
            </dependency>
+            <dependency>
+                <groupId>org.opengauss</groupId>
+                <artifactId>opengauss-jdbc</artifactId>


check license as `BSD 2-clause’

slievrly · 2023-12-06T03:54:11Z

dependencies/pom.xml

        <!-- db connection pool -->
-        <druid.version>1.2.7</druid.version>
+        <druid.version>1.2.12</druid.version>


why upgrade the druid version, Is there any compatibility issue between this database and Druid?

Druid 1.2.12 is the lowest supported version of openGauss

slievrly · 2023-12-06T03:54:15Z

dependencies/pom.xml

        <!-- db connection pool -->
-        <druid.version>1.2.7</druid.version>
+        <druid.version>1.2.12</druid.version>


why upgrade the druid version, Is there any compatibility issue between this database and Druid?

# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md

codecov-commenter · 2024-01-02T02:49:23Z

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 49.64%. Comparing base (d2dbbff) to head (386df09).
Report is 312 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
.../druid/gaussdb/GaussDBOperateRecognizerHolder.java	0.00%	8 Missing ⚠️
...source/undo/gaussdb/GaussDBUndoExecutorHolder.java	0.00%	4 Missing ⚠️
.../undo/postgresql/PostgresqlUndoUpdateExecutor.java	0.00%	4 Missing ⚠️
...source/undo/gaussdb/GaussDBUndoDeleteExecutor.java	0.00%	3 Missing ⚠️
...source/undo/gaussdb/GaussDBUndoInsertExecutor.java	0.00%	3 Missing ⚠️
...source/undo/gaussdb/GaussDBUndoUpdateExecutor.java	0.00%	3 Missing ⚠️
.../undo/postgresql/PostgresqlUndoDeleteExecutor.java	0.00%	3 Missing ⚠️
.../undo/postgresql/PostgresqlUndoInsertExecutor.java	0.00%	3 Missing ⚠️
...lparser/druid/gaussdb/GaussDBDeleteRecognizer.java	0.00%	3 Missing ⚠️
...lparser/druid/gaussdb/GaussDBInsertRecognizer.java	0.00%	3 Missing ⚠️
... and 12 more

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6020      +/-   ##
============================================
+ Coverage     48.98%   49.64%   +0.66%     
- Complexity     4779     4895     +116     
============================================
  Files           915      930      +15     
  Lines         31896    31946      +50     
  Branches       3855     3856       +1     
============================================
+ Hits          15624    15860     +236     
+ Misses        14710    14526     -184     
+ Partials       1562     1560       -2

Files with missing lines	Coverage Δ
...n/src/main/java/io/seata/common/util/PageUtil.java	`55.17% <ø> (ø)`
...ta/core/store/db/sql/lock/GaussDBLockStoreSql.java	`0.00% <0.00%> (ø)`
...ata/core/store/db/sql/log/GaussDBLogStoreSqls.java	`0.00% <0.00%> (ø)`
...n/java/io/seata/rm/datasource/DataSourceProxy.java	`60.00% <0.00%> (-0.58%)`	⬇️
...urce/sql/handler/gaussdb/GaussDBEscapeHandler.java	`0.00% <0.00%> (ø)`
...source/sql/struct/cache/GaussDBTableMetaCache.java	`0.00% <0.00%> (ø)`
...datasource/undo/gaussdb/GaussDBUndoLogManager.java	`0.00% <0.00%> (ø)`
...in/java/io/seata/sqlparser/util/JdbcConstants.java	`0.00% <0.00%> (ø)`
.../src/main/java/io/seata/core/constants/DBType.java	`0.00% <0.00%> (ø)`
...datasource/exec/gaussdb/GaussDBInsertExecutor.java	`0.00% <0.00%> (ø)`
... and 13 more

... and 24 files with indirect coverage changes

support openGuass and GuassDB

c5be9cf

liuqiufeng changed the title ~~support openGuass and GuassDB~~ feature: support openGuass and GuassDB Nov 11, 2023

Merge remote-tracking branch 'upstream/2.x' into 2.x_opengauss

27b927c

funky-eyes added type: feature Category issues or prs related to feature request. mode: AT AT transaction mode module/rm-datasource rm-datasource module module/sqlparser sql-parser module labels Nov 11, 2023

funky-eyes added this to the 2.x Backlog milestone Nov 11, 2023

Merge branch '2.x' into 2.x_opengauss

1e7fc83

liuqiufeng changed the title ~~feature: support openGuass and GuassDB~~ feature: support openGuass and GuassDB in AT mode Nov 27, 2023

liuqiufeng added 3 commits November 27, 2023 09:52

fix code style & registrations

37405cf

fix code style

554e658

Merge remote-tracking branch 'upstream/2.x' into 2.x_opengauss

bbc3eb0

funky-eyes modified the milestones: 2.x Backlog, 2.1.0 Dec 1, 2023

Merge branch '2.x' into 2.x_opengauss

44b0c75

funky-eyes reviewed Dec 1, 2023

View reviewed changes

script/server/db/postgresql.sql Outdated Show resolved Hide resolved

liuqiufeng added 2 commits December 1, 2023 17:10

rollback sql that should not be modified

8c4a3d1

rollback sql that should not be modified

1016788

funky-eyes previously approved these changes Dec 4, 2023

View reviewed changes

funky-eyes requested a review from slievrly December 4, 2023 02:05

Merge branch '2.x' into 2.x_opengauss

9173060

slievrly reviewed Dec 6, 2023

View reviewed changes

xingfudeshi and others added 4 commits December 8, 2023 10:38

Merge branch '2.x' into 2.x_opengauss

6ba3ac5

Merge branch '2.x' into 2.x_opengauss

bf6203e

Merge branch '2.x' into 2.x_opengauss

036d6de

调整copyright

311d23f

liuqiufeng dismissed funky-eyes’s stale review via 311d23f January 2, 2024 02:15

Merge branch '2.x' into 2.x_opengauss

920e683

# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md

liuqiufeng added 2 commits January 4, 2024 09:43

调整注释

35dcf79

bug修复及优化

386df09

slievrly removed this from the 2.1.0 milestone Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support openGuass and GuassDB in AT mode #6020

feature: support openGuass and GuassDB in AT mode #6020

liuqiufeng commented Nov 11, 2023

codecov bot commented Nov 27, 2023 •

edited

Loading

funky-eyes left a comment

slievrly Dec 6, 2023

liuqiufeng Dec 6, 2023

slievrly Dec 6, 2023

liuqiufeng Dec 6, 2023

slievrly Dec 6, 2023

codecov-commenter commented Jan 2, 2024 •

edited by codecov bot

Loading

feature: support openGuass and GuassDB in AT mode #6020

Are you sure you want to change the base?

feature: support openGuass and GuassDB in AT mode #6020

Conversation

liuqiufeng commented Nov 11, 2023

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov bot commented Nov 27, 2023 • edited Loading

Codecov Report

funky-eyes left a comment

Choose a reason for hiding this comment

slievrly Dec 6, 2023

Choose a reason for hiding this comment

liuqiufeng Dec 6, 2023

Choose a reason for hiding this comment

slievrly Dec 6, 2023

Choose a reason for hiding this comment

liuqiufeng Dec 6, 2023

Choose a reason for hiding this comment

slievrly Dec 6, 2023

Choose a reason for hiding this comment

codecov-commenter commented Jan 2, 2024 • edited by codecov bot Loading

Codecov Report

codecov bot commented Nov 27, 2023 •

edited

Loading

codecov-commenter commented Jan 2, 2024 •

edited by codecov bot

Loading