Support keep alive clients console #4816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add view about keep-alive-clients
1. add logic about offline keep-alive-clients. 2. refactor Result and so on. 3. add ConsoleException and ConsoleExceptionHandler.
1. add comments. 2. add NetUtilTest#TestIsCorrectFormatAddress Signed-off-by: TheR1sing3un <[email protected]>
1. format changed code Signed-off-by: TheR1sing3un <[email protected]>
…le' into support_keep_alive_clients_console
1. format changed code Signed-off-by: TheR1sing3un <[email protected]>
1. format imports Signed-off-by: TheR1sing3un <[email protected]>
|
@slievrly PING! Please check! |
Codecov Report
@@ Coverage Diff @@
## develop #4816 +/- ##
=============================================
- Coverage 48.78% 48.34% -0.44%
- Complexity 4081 4087 +6
=============================================
Files 734 740 +6
Lines 25855 26098 +243
Branches 3191 3214 +23
=============================================
+ Hits 12614 12618 +4
- Misses 11899 12134 +235
- Partials 1342 1346 +4
|
slievrly
reviewed
Aug 23, 2022
| * @return true if the given address match the format ip:host | ||
| */ | ||
| public static boolean isCorrectFormatAddress(String address) { | ||
| if (address.split(":").length == 2 && isValidIp(address.split(":")[0], true) && isPort(address.split(":")[1])) { |
slievrly
reviewed
Aug 24, 2022
console/src/main/java/io/seata/console/handler/ConsoleExceptionHandler.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Aug 24, 2022
1. add console's frontend about client info
1. fix the client search condition
1. fix the client search condition
1. fix some style
1. fix some style
1. fix some style
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
SummerCode2022：#4621 (comment)
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
unit test
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews