Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the problem that the number of mirrors before and after may be inconsistent #4748

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jul 6, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

1.update count大于 before size时,抛出异常
2.当update的where条件中没有主键时,后镜像采用前镜像方式制作,且进行对比前后镜像查询的行数结果

Ⅱ. Does this pull request fix one issue?

fixes #4727

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added the module/rm-datasource rm-datasource module label Sep 7, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Merging #4748 (504fade) into develop (acf880a) will increase coverage by 0.02%.
The diff coverage is 59.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4748      +/-   ##
=============================================
+ Coverage      49.29%   49.31%   +0.02%     
- Complexity      4126     4144      +18     
=============================================
  Files            736      737       +1     
  Lines          26130    26199      +69     
  Branches        3226     3241      +15     
=============================================
+ Hits           12880    12921      +41     
- Misses         11870    11894      +24     
- Partials        1380     1384       +4     
Impacted Files Coverage Δ
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 50.90% <0.00%> (-6.24%) ⬇️
...eata/rm/datasource/exec/LockConflictException.java 75.00% <ø> (ø)
...parser/antlr/mysql/AntlrMySQLUpdateRecognizer.java 0.00% <0.00%> (ø)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 7.01% <0.00%> (-0.26%) ⬇️
...r/druid/postgresql/PostgresqlUpdateRecognizer.java 7.01% <0.00%> (-0.26%) ⬇️
.../seata/rm/datasource/exec/LockRetryController.java 86.66% <33.33%> (-4.04%) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.50% <50.00%> (+0.33%) ⬆️
.../io/seata/rm/datasource/exec/TxRetryException.java 66.66% <66.66%> (ø)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 78.57% <84.61%> (-1.43%) ⬇️
.../java/io/seata/sqlparser/druid/BaseRecognizer.java 82.66% <90.90%> (+6.47%) ⬆️
... and 3 more

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@b550f11). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4748   +/-   ##
==========================================
  Coverage           ?   48.36%           
  Complexity         ?     4162           
==========================================
  Files              ?      795           
  Lines              ?    28155           
  Branches           ?     3442           
==========================================
  Hits               ?    13617           
  Misses             ?    13109           
  Partials           ?     1429           
Files Coverage Δ
...eata/rm/datasource/exec/LockConflictException.java 75.00% <ø> (ø)
.../io/seata/rm/datasource/exec/TxRetryException.java 66.66% <66.66%> (ø)
.../seata/rm/datasource/exec/LockRetryController.java 86.66% <33.33%> (ø)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 87.50% <84.61%> (ø)
...o/seata/sqlparser/druid/dm/DmUpdateRecognizer.java 0.00% <0.00%> (ø)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 61.00% <0.00%> (ø)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 7.01% <0.00%> (ø)
...r/druid/postgresql/PostgresqlUpdateRecognizer.java 7.01% <0.00%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 26.00% <50.00%> (ø)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 48.33% <16.66%> (ø)
... and 2 more

@funky-eyes funky-eyes changed the title bugfix: before and after image rows under read commit is size not equals bugfix: the problem that the number of mirrors before and after may be inconsistent Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT模式在oracle和postgresql中回滚逻辑实现不正确。
4 participants