Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : skip list for undo data validation #4585

Open
wants to merge 16 commits into
base: 2.x
Choose a base branch
from

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented May 6, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

新增配置client.undo.dataValidation.skip ,表示可跳过校验的列表(以,分隔)
此配置在client.undo.dataValidation = true时生效。
满足跳过的逻辑是:beforeImage, afterImage , currentImage 其中某个的tableName存在于这个skip列表中
新增了test,以及修复了之前test不严谨的部分(由于tableMeta被mock了所以setTableMeta会覆盖掉tableName)

Ⅱ. Does this pull request fix one issue?

fixes #4566

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue Bughue closed this May 7, 2022
@Bughue Bughue force-pushed the dev-undo-dataValidation branch from 711ab3c to 8a12ddc Compare May 7, 2022 02:19
@Bughue Bughue reopened this May 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #4585 (9f44c76) into 2.x (e69627d) will decrease coverage by 0.14%.
The diff coverage is 76.47%.

❗ Current head 9f44c76 differs from pull request most recent head fa005ad. Consider uploading reports for the commit fa005ad to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #4585      +/-   ##
============================================
- Coverage     48.73%   48.60%   -0.14%     
+ Complexity     4339     4319      -20     
============================================
  Files           778      775       -3     
  Lines         27454    27401      -53     
  Branches       3412     3408       -4     
============================================
- Hits          13380    13317      -63     
- Misses        12677    12685       +8     
- Partials       1397     1399       +2     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 68.70% <75.00%> (-0.31%) ⬇️
.../java/io/seata/rm/datasource/DataCompareUtils.java 66.99% <77.77%> (+2.04%) ⬆️

... and 23 files with indirect coverage changes

@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/rm-datasource rm-datasource module labels Sep 21, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Bughue
❌ wangliang181230
You have signed the CLA already but the status is still pending? Let us recheck it.

@Bughue Bughue changed the base branch from develop to 2.x February 1, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine the granularity of dataValidation functionality
6 participants