-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : skip list for undo data validation #4585
base: 2.x
Are you sure you want to change the base?
Conversation
711ab3c
to
8a12ddc
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## 2.x #4585 +/- ##
============================================
- Coverage 48.73% 48.60% -0.14%
+ Complexity 4339 4319 -20
============================================
Files 778 775 -3
Lines 27454 27401 -53
Branches 3412 3408 -4
============================================
- Hits 13380 13317 -63
- Misses 12677 12685 +8
- Partials 1397 1399 +2
|
|
Ⅰ. Describe what this PR did
新增配置client.undo.dataValidation.skip ,表示可跳过校验的列表(以,分隔)
此配置在client.undo.dataValidation = true时生效。
满足跳过的逻辑是:beforeImage, afterImage , currentImage 其中某个的tableName存在于这个skip列表中。
新增了test,以及修复了之前test不严谨的部分(由于tableMeta被mock了所以setTableMeta会覆盖掉tableName)
Ⅱ. Does this pull request fix one issue?
fixes #4566
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews