feature: support flow limiting control for a single server #4053

YSF-A · 2021-09-30T13:40:51Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

Support flow limiting control for a single server

Ⅱ. Does this pull request fix one issue?

fixes #3747

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly · 2021-10-08T04:16:41Z

server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java

+                RateLimiter ratelimiter = EnhancedServiceLoader.load(RateLimiter.class);
+                ratelimiterMap.put(transactionRequest.getClass(), ratelimiter);
+            }
+            if (!ratelimiterMap.get(transactionRequest.getClass()).canPass()) {


return limit information to client.

slievrly · 2021-10-08T04:24:24Z

server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java

@@ -151,6 +157,8 @@

    private static volatile DefaultCoordinator instance;

+    private Map<Class, RateLimiter> ratelimiterMap = new ConcurrentHashMap<>();


warp the map into a class. In addition, not all types need limiting.

codecov-commenter · 2021-10-09T04:24:11Z

Codecov Report

Merging #4053 (07a2b0e) into 2.0.0 (8590bbf) will increase coverage by 0.14%.
The diff coverage is 3.37%.

❗ Current head 07a2b0e differs from pull request most recent head 66a8542. Consider uploading reports for the commit 66a8542 to get more accurate results

@@             Coverage Diff              @@
##              2.0.0    #4053      +/-   ##
============================================
+ Coverage     49.08%   49.23%   +0.14%     
+ Complexity     3772     3752      -20     
============================================
  Files           719      702      -17     
  Lines         23948    23653     -295     
  Branches       2926     2919       -7     
============================================
- Hits          11755    11645     -110     
+ Misses        10989    10823     -166     
+ Partials       1204     1185      -19

Impacted Files	Coverage Δ
...ava/io/seata/core/constants/ConfigurationKeys.java	`0.00% <ø> (ø)`
...rpc/processor/server/ServerOnRequestProcessor.java	`0.00% <0.00%> (ø)`
...ta/spring/boot/autoconfigure/StarterConstants.java	`100.00% <ø> (ø)`
...configure/SeataServerEnvironmentPostProcessor.java	`0.00% <0.00%> (ø)`
.../io/seata/server/ratelimit/TokenBucketLimiter.java	`0.00% <0.00%> (ø)`
...e/properties/server/ServerRatelimitProperties.java	`7.69% <7.69%> (ø)`
...o/seata/server/coordinator/DefaultCoordinator.java	`41.75% <25.00%> (-6.10%)`	⬇️
...java/io/seata/server/metrics/MeterIdConstants.java	`0.00% <0.00%> (-100.00%)`	⬇️
...ava/io/seata/server/metrics/MetricsSubscriber.java	`18.84% <0.00%> (-53.63%)`	⬇️
... and 53 more

slievrly · 2021-11-08T12:24:06Z

server/src/main/java/io/seata/server/ratelimit/TokenBucketLimiter.java

        this.microSecondsPerToken = TimeUnit.SECONDS.toMicros(1L) / requestsPerSecond;
-        this.burst = CONFIG.getInt(ConfigurationKeys.BURST, (int)microSecondsPerToken);
+        this.burst = Double.parseDouble(CONFIG.getConfig(ConfigurationKeys.BURST, String.valueOf(requestsPerSecond)));


if the configuration content not a parsable double, throw exception?

slievrly

LGTM

slievrly · 2021-11-08T12:28:06Z

@YSF-A Pls pay attention to the following unit test failure.

server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java

server/src/main/java/io/seata/server/ratelimit/RateLimitedResponseMap.java

server/src/main/java/io/seata/server/ratelimit/TokenBucketLimiter.java

funky-eyes · 2021-11-09T10:00:21Z

server/src/main/java/io/seata/server/ratelimit/TokenBucketLimiter.java

+    }
+
+    public boolean acquire() {
+        long waitTimeInMicros = tryGetTokenWithDelay();


如果允许delay，应该加上timeout参数，在允许的实际内自旋/sleep等待令牌，如果超出了时间没得到应该失败，而不是等一会直接就允许通过

timeout 是否应该放在入参一份，以便不同场景都可复用，当timeout为空再用配置中心的配置

server/src/test/java/io/seata/server/ratelimit/TokenBucketRateLimiterTest.java

tm/src/main/java/io/seata/tm/DefaultTransactionManager.java

…g time

… protobuf

…ceptionCode.java and transactionExceptionCode.proto

The base branch was changed.

lgtm-com · 2021-12-20T06:29:13Z

This pull request introduces 7 alerts when merging c337b96 into 6f877fa - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

CLAassistant · 2022-12-12T13:18:36Z

All committers have signed the CLA.

CLAassistant · 2022-12-12T13:18:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ YSF-A
❌ slievrly
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

YSF-A added 3 commits September 30, 2021 19:13

feature: support flow limiting control for a single Server

080d799

optimize: optimize TokenBucketLimiterTest

d95d929

checkstyle

c888d19

slievrly reviewed Oct 8, 2021

View reviewed changes

slievrly added the Summer2021 label Oct 9, 2021

slievrly added this to the 2.0.0 milestone Oct 9, 2021

Merge branch 'develop' into feature_support_flowlimit

07a2b0e

YSF-A and others added 7 commits October 14, 2021 23:55

optimize: return limit information to client

3a0bb73

optimize: use only one RateLimiter in DefaultCoordinator

f0c280c

bugfix: fix the returned limit information

214a707

optimize: optimize parameters and config of TokenBucketLimiter

dede8d1

optimize: optimize config of rate limited request and response

e7d48cd

checkstyle

7091df6

Merge branch 'develop' into feature_support_flowlimit

befe772

slievrly reviewed Nov 8, 2021

View reviewed changes

slievrly previously approved these changes Nov 8, 2021

View reviewed changes

funky-eyes requested changes Nov 9, 2021

View reviewed changes

YSF-A added 2 commits November 17, 2021 11:26

optimize: throw exception if configuration content is not parsable

e73e3c6

bugfix: fix the failure of the unit test TransactionExceptionCodeTest

f84e3ee

YSF-A added 7 commits November 22, 2021 22:42

optimize: use ResultCode.RateLimited instead of ResultCode.Failed

aad2359

optimize: add parameter timeout in the TokenBucketLimiter

3fb7325

bugfix: use RateLimited and delete unused judge of Failed

6faa4c5

optimize: use rateLimited exception code instead of failure

3c3c93a

optimize: add the runtime exception of rateLimited

7873368

optimize: update FailureHandler to handle RateLimited

bc480ce

optimize: use FailureHandler to handle rateLimited in the TM

45d8454

YSF-A and others added 13 commits December 13, 2021 21:59

optimize: handle ratelimited in the TM for SAGA

49d755a

optimize: handle rateLimited in the RM

1a78d4e

optimize: handle rateLimited in the RM for TCC

9771652

optimize: rollback immediately to avoid holding global lock for a lon…

bb932cd

…g time

bugfix: fix the bug of TransactionExceptionCodeTest

19bf13b

optimize: use SINGLETON instead of PROTOTYPE for TokenBucketLimiter

075026d

optimize: change the test to standard style

47f382c

optimize: add test in the DefaultFailureHandlerImplTest

78bbeca

optimize: avoid encode error when serialization is protobuf

ed7c7ac

optimize: set default XID to avoid encode error when serialization is…

e7ce011

… protobuf

bugfix: add BeginFailed to maintain consistency between TransactionEx…

019939b

…ceptionCode.java and transactionExceptionCode.proto

checkstyle

eafde9c

Merge branch 'develop' into feature_support_flowlimit

c337b96

YSF-A changed the base branch from develop to 2.0.0 December 20, 2021 06:00

YSF-A changed the base branch from 2.0.0 to develop December 20, 2021 06:04

YSF-A changed the base branch from develop to 2.0.0 December 28, 2021 05:55

YSF-A added 2 commits December 28, 2021 22:03

optimize: record rate limited information through prometheus

8797963

optimize: add the parameter timeout

66a8542

YSF-A requested a review from funky-eyes December 29, 2021 06:07

funky-eyes modified the milestones: 2.0.0, 2.x Backlog Nov 4, 2023

slievrly changed the base branch from 2.0.0 to 2.x November 20, 2023 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support flow limiting control for a single server #4053

feature: support flow limiting control for a single server #4053

YSF-A commented Sep 30, 2021

slievrly Oct 8, 2021

slievrly Oct 8, 2021

codecov-commenter commented Oct 9, 2021 •

edited

Loading

slievrly Nov 8, 2021

slievrly left a comment

slievrly commented Nov 8, 2021

funky-eyes Nov 9, 2021

funky-eyes Dec 22, 2021

lgtm-com bot commented Dec 20, 2021

CLAassistant commented Dec 12, 2022 •

edited

Loading

CLAassistant commented Dec 12, 2022

		@@ -151,6 +157,8 @@

		private static volatile DefaultCoordinator instance;

		private Map<Class, RateLimiter> ratelimiterMap = new ConcurrentHashMap<>();

feature: support flow limiting control for a single server #4053

Are you sure you want to change the base?

feature: support flow limiting control for a single server #4053

Conversation

YSF-A commented Sep 30, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly Oct 8, 2021

Choose a reason for hiding this comment

slievrly Oct 8, 2021

Choose a reason for hiding this comment

codecov-commenter commented Oct 9, 2021 • edited Loading

Codecov Report

slievrly Nov 8, 2021

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

slievrly commented Nov 8, 2021

funky-eyes Nov 9, 2021

Choose a reason for hiding this comment

funky-eyes Dec 22, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Dec 20, 2021

CLAassistant commented Dec 12, 2022 • edited Loading

CLAassistant commented Dec 12, 2022

codecov-commenter commented Oct 9, 2021 •

edited

Loading

CLAassistant commented Dec 12, 2022 •

edited

Loading