fix: undo log sql #724
Merged
fix: undo log sql #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luky116
reviewed
Dec 7, 2024
| @@ -121,6 +121,10 @@ func (b *BasicUndoLogBuilder) traversalArgs(node ast.Node, argsIndex *[]int32) { | |||
| b.traversalArgs(exprs[i], argsIndex) | |||
| } | |||
| break | |||
| case *ast.ParenthesesExpr: | |||
|
luky116
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix the problem of
MySQLUpdateUndoLogBuilderfailing to generate undo log sql.The reason for the failure is that
BasicUndoLogBuilder.traversalArgsignores the processing of theParenthesesExprnode when recursively traversing ast.Solved after adding the following code:
Which issue(s) this PR fixes:
Fixes #593
Special notes for your reviewer:
Test samples for this issue have been added and all test cases have passed.
Does this PR introduce a user-facing change?: