optimize: optimize the speed of buildLockKey #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
把单元测试也完善下 |
好的 |
Code-Fight
suggested changes
Dec 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
optimize the speed of buildLockKey
K: The number of primary keys
M: The number of columns
N: The number of rows
Original time complexity:$O(N \times M \times K)$ $O(N \times K)$
Optimized time complexity:
Which issue(s) this PR fixes:
Fixes #696
Special notes for your reviewer:
It has been tested locally and can pass the corresponding unit test.
Does this PR introduce a user-facing change?: