Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Reclaim the heartbeat response message to avoid memory leakage of GettyRemoting.futures #648

Closed
wants to merge 1 commit into from
Closed

fix:Reclaim the heartbeat response message to avoid memory leakage of GettyRemoting.futures #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/remoting/processor/client/client_heart_beat_processon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,11 @@ func (f *clientHeartBeatProcessor) Process(ctx context.Context, rpcMessage messa
log.Debug("received PONG from {}", ctx)
}
}
msgFuture := getty.GetGettyRemotingInstance().GetMessageFuture(rpcMessage.ID)
if msgFuture != nil {
// 心跳消息目前没有处理逻辑，所以这里不能notify，否则会导致msgFuture.Done阻塞
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把中文去了

// getty.GetGettyRemotingInstance().NotifyRpcMessageResponse(rpcMessage)
getty.GetGettyRemotingInstance().RemoveMessageFuture(rpcMessage.ID)
}
return nil
}
Loading