【等CI结束就合并】feat: Implement the discovery service by Etcd #605
Conversation
|
|
| EtcdClusterPrefix = "registry-seata" | ||
| ) | ||
|
|
||
| type EtcdRegistryService struct { |
There was a problem hiding this comment.
给EtcdRegistryService编写完整的单元测试
There was a problem hiding this comment.
@iSuperCoder 你好，已经加上单元测试了，还需要补充什么吗？
|
@yizhibian CI没通过。 |
@yizhibian CI failed. |
|
@iSuperCoder 你好，我参考了nacos_test重写了etcd3的单元测试，并且在测试分支上通过了所有workflows，请检查一下我的代码，如果有存在问题的话我会尽快修改，谢谢 |
@iSuperCoder Hello, I rewrote the unit tests of etcd3 with reference to nacos_test, and passed all workflows on the test branch. Please check my code. If there are any problems, I will modify them as soon as possible. Thank you. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 37.28% 37.68% +0.39%
==========================================
Files 175 175
Lines 11666 11837 +171
==========================================
+ Hits 4350 4461 +111
- Misses 6952 6996 +44
- Partials 364 380 +16
☔ View full report in Codecov by Sentry. |
luky116
changed the title
What this PR does:
Implement the discovery service by Etcd.
Which issue(s) this PR fixes:
Fixes #578
Special notes for your reviewer:
I use Etcd to watch all the kvs with prefix like
registry-seata, since it works correctly, but I am not sure if it suitable or that have some other more elegant ways. Please give me some advices, I am glad to fix it.Does this PR introduce a user-facing change?:
NONE