fix(meta): fix null pointer while deleting environment variables after table was dropped #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r table was dropped
acelyc111
reviewed
Dec 16, 2024
src/meta/server_state.cpp
Outdated
| } | ||
|
|
||
| deleted_keys_info += fmt::format("\n {}", key); |
There was a problem hiding this comment.
Will fmt::format_to be faster than std::string + operator?
There was a problem hiding this comment.
OK, I'll use fmt::format_to instead.
acelyc111
approved these changes
Dec 17, 2024
Samunroyu
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2149.
Previously we've fixed the problem that meta server failed due to null pointer while
deleting environment variables locally immediately after a table was dropped in
#2148. There's the same problem
while deleting environment variables.