Skip to content

Commit

Permalink
add comment in the code about protobuf version
Browse files Browse the repository at this point in the history
  • Loading branch information
rgdoliveira committed Aug 1, 2023
1 parent b9fa8ec commit ad59300
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
diff --git a/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml b/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
index c2ca6f930..b681d6347 100644
index c2ca6f930..a50429305 100644
--- a/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
+++ b/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
@@ -15,8 +15,8 @@
@@ -15,8 +15,9 @@
<version.compiler.plugin>3.8.1</version.compiler.plugin>
<maven.compiler.release>11</maven.compiler.release>
<version.surefire.plugin>3.0.0-M7</version.surefire.plugin>
- <version.com.google.protobuf>3.22.0</version.com.google.protobuf>
- <version.io.grpc>1.51.1</version.io.grpc>
+ <!-- Quarkus 2.13.x is using protobuf 3.19.6, but the correct version should be 3.21.1 to work properly with current io.grpc version -->
+ <version.com.google.protobuf>3.21.1</version.com.google.protobuf>
+ <version.io.grpc>1.49.0</version.io.grpc>
<version.kr.motd.maven.os>1.6.0</version.kr.motd.maven.os>
<version.org.xolstice.maven.protobuf>0.6.1</version.org.xolstice.maven.protobuf>
<version.jib-maven-plugin>3.3.0</version.jib-maven-plugin>
--
2.41.0

0 comments on commit ad59300

Please sign in to comment.