Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1829] Fix zero-seconds truncation on date time #6255

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Feb 13, 2025

Fixes apache/incubator-kie-issues#1829

TCK diff

Before PR
> "compliance-level-3/1116-feel-time-function","1116-feel-time-function-test-01","036_eb05fabc01","ERROR","FAILURE: 'feel-time-function_036_eb05fabc01' expected='10:20:00@Europe/Paris' but found='10:20@Europe/Paris'"
> "compliance-level-3/1116-feel-time-function","1116-feel-time-function-test-01","037_eed195f693","ERROR","FAILURE: 'feel-time-function_037_eed195f693' expected='11:20:00@Asia/Dhaka' but found='11:20@Asia/Dhaka'"

After PR
< "compliance-level-3/1116-feel-time-function","1116-feel-time-function-test-01","036_eb05fabc01","SUCCESS",""
< "compliance-level-3/1116-feel-time-function","1116-feel-time-function-test-01","037_eed195f693","SUCCESS",""

21 Errors left

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-2

@gitgabrio gitgabrio merged commit 8419e52 into apache:main Feb 17, 2025
10 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1829 branch February 17, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN - TCK failure: Wrong date-time format
3 participants