Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator-kie-drools-6163] Clean up leftover of change-set support #6188

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[incubator-kie-drools-6163] Clean up leftover of change-set support #6188

merged 2 commits into from
Dec 13, 2024

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Dec 6, 2024

@tkobayas tkobayas requested a review from yesamer December 10, 2024 05:38
yesamer
yesamer reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkobayas Thank you for this cleanup task.
Can you please update the rat-excludes file accordingly with the removed files?
In addition, I searched for changeSet key in the repo, and I found 240+ usages. Are those usage still required?

Screenshot 2024-12-10 at 07 44 23

@tkobayas
Copy link
Contributor Author

Hi @yesamer ,

Can you please update the rat-excludes file accordingly with the removed files?

Thank you! I completely forgot the point. Fixed.

In addition, I searched for changeSet key in the repo, and I found 240+ usages. Are those usage still required?

Yes. Some classes use the name ChangeSet for different capability, which handles differences between current version and next version of kieModule. They are still required.

This PR removed the feature related to "change-set.xml" file, which is no longer functional nor tested.

yesamer
yesamer approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tkobayas

@tkobayas
Copy link
Contributor Author

re-running GHA

@tkobayas
Copy link
Contributor Author

Test failures on CallbackStateTimeoutsIT, MultipleTimerInstancesIT etc. are being solved by apache/incubator-kie-kogito-runtimes#3814

@tkobayas tkobayas merged commit 0b34f19 into apache:main Dec 13, 2024
9 of 10 checks passed
@tkobayas tkobayas mentioned this pull request Dec 13, 2024
Closed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Dec 17, 2024
@tkobayas @rgdoliveira
[incubator-kie-drools-6163] Clean up leftover of change-set support (a…
018a98b 
…pache#6188)

* [incubator-kie-drools-6163] Clean up leftover of change-set support

* remove .rat-excludes entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesamer yesamer yesamer approved these changes

@mariofusco mariofusco mariofusco approved these changes

@baldimir baldimir baldimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkobayas @baldimir @mariofusco @yesamer