Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionFieldValue clone #5991

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Jun 13, 2024

Fixes wrong clone of ActionFieldValue

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio gitgabrio requested review from Rikkola and yesamer June 13, 2024 14:09
@Rikkola
Copy link
Contributor

Rikkola commented Jun 13, 2024

I will do a quick check to see why the @{} are not cleared.

@yesamer yesamer changed the title [private-bamoe-issues#2091] Fix ActionFieldValue clone Fix ActionFieldValue clone Jun 13, 2024
@yesamer
Copy link
Contributor

yesamer commented Jun 14, 2024

@Rikkola May you please approve it?

@gitgabrio gitgabrio merged commit 689b0b7 into apache:7.67.x-blue Jun 14, 2024
@gitgabrio gitgabrio deleted the private-bamoe-issues#2091 branch June 14, 2024 08:31
yesamer pushed a commit to yesamer/drools that referenced this pull request Jul 10, 2024
* [private-bamoe-issues#2091] Fix ActionFieldValue clone

* Fix template test

* [private-bamoe-issues#2091] Fix ActionFieldValue clone

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
Co-authored-by: rikkola <[email protected]>
yesamer added a commit to kiegroup/drools that referenced this pull request Jul 17, 2024
* [private-bamoe-issues#2091] Fix ActionFieldValue clone

* Fix template test

* [private-bamoe-issues#2091] Fix ActionFieldValue clone

---------

Co-authored-by: Gabriele Cardosi <[email protected]>
Co-authored-by: Gabriele-Cardosi <[email protected]>
Co-authored-by: rikkola <[email protected]>
gitgabrio added a commit to gitgabrio/drools that referenced this pull request Jul 19, 2024
* [private-bamoe-issues#2091] Fix ActionFieldValue clone

* Fix template test

* [private-bamoe-issues#2091] Fix ActionFieldValue clone

---------

Co-authored-by: Gabriele Cardosi <[email protected]>
Co-authored-by: Gabriele-Cardosi <[email protected]>
Co-authored-by: rikkola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants