-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(store): translate CJK comments to English for store-dist, store-grpc, store-node, store-rocksdb, store-test #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Peng Junzhi <[email protected]>
This reverts commit 9ebdb3e.
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
store
Store module
labels
Aug 22, 2024
40 tasks
imbajin
approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
============================================
- Coverage 47.14% 46.80% -0.35%
+ Complexity 583 343 -240
============================================
Files 718 718
Lines 58469 58469
Branches 7496 7496
============================================
- Hits 27568 27366 -202
- Misses 28122 28324 +202
Partials 2779 2779 ☔ View full report in Codecov by Sentry. |
JackyYangPassion
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #2624
subtask of #2575
Except for some Chinese character tests in https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-store/hg-store-test/src/main/java/org/apache/hugegraph/store/util/UnsafeUtilTest.java.