-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pd): integrate pd-grpc
&pd-common
&pd-client
#2498
Conversation
pd-grpc
, pd-common
, pd-client
into hugegraphpd-grpc
, pd-common
, pd-client
into hugegraph
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
============================================
- Coverage 66.31% 65.67% -0.64%
+ Complexity 829 827 -2
============================================
Files 511 518 +7
Lines 42649 42987 +338
Branches 5942 5976 +34
============================================
- Hits 28281 28233 -48
- Misses 11557 11938 +381
- Partials 2811 2816 +5 ☔ View full report in Codecov by Sentry. |
@@ -199,7 +199,7 @@ | |||
<!-- TODO: uncomment for checking dependency conflicts --> | |||
<!-- <DependencyConvergence/> --> | |||
<requireJavaVersion> | |||
<version>[1.8,12)</version> | |||
<version>[11,)</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imbajin Do we enforce a specific Java version here, abandoning Java 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imbajin Do we enforce a specific Java version here, abandoning Java 8?
In my view, Yes (we could just define it in the root pom?)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
============================================
- Coverage 63.83% 63.15% -0.69%
+ Complexity 829 827 -2
============================================
Files 511 518 +7
Lines 42649 42987 +338
Branches 5942 5976 +34
============================================
- Hits 27225 27148 -77
- Misses 12677 13088 +411
- Partials 2747 2751 +4 ☔ View full report in Codecov by Sentry. |
Note: set version to |
pd-grpc
, pd-common
, pd-client
into hugegraphpd-grpc
&pd-common
&pd-client
1. prepare pom and CI for pd-client, pd-common, pd-grpc and pd-test 2. drop support for java8
prepare tests for `pd-common`
subtask of #2481
merge #2460 to master