-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pd): refactor and fix pd tests #2492
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pd-store #2492 +/- ##
===========================================
Coverage ? 56.82%
Complexity ? 2156
===========================================
Files ? 717
Lines ? 58318
Branches ? 7482
===========================================
Hits ? 33140
Misses ? 21943
Partials ? 3235 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relative doc & previous issues help me a lot :)
Miss some context before reading them
subtask of #2481
pd-clitools
module (replace withpd-cli
when adapting 4.0)DiscoveryClientImplTest
, althoughDiscoveryClientImpl
is still retained inpd-client
PDCoreTestBase
to reuse thePDConfig
constructionFor detailed documentation, please refer to this link.