This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: make create table idempotent #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
changed the title
ZuLiangWang
force-pushed
the
refactor_create_table
branch
3 times, most recently
from
faa73fd to
90069e5
Compare
ZuLiangWang
force-pushed
the
refactor_create_table
branch
2 times, most recently
from
f1d0cdc to
edc14a5
Compare
## Rationale Due to misconfiguration of the ProcedureID Allocator storage path in ETCD, multiple clusters will share the same ProcedureID Allocator, which will cause ID to be wasted. ## Detailed Changes * Fix wrong ID allocator storage path. ## Test Plan Pass CI.
## Rationale The current design of the procedure storage module is unreasonable. The data will be stored permanently and will not be cleared. This will cause the storage space of `ETCD` to be filled up quickly. We need to redesign the interface of procedure storage. ## Detailed Changes * Add `ttl` config for `CreateOrUpdate`. * Add `Delete` interface, it used to delete history procedure data and current procedure data. ## Test Plan Pass all unit tests and integration tests.
ZuLiangWang
force-pushed
the
refactor_create_table
branch
from
edc14a5 to
baa64ee
Compare
|
We are currently developing based on the dev branch. Close this PR and re-submit to the dev branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Store the intermediate data for table creation through procedures to support idempotent table creation.
Detailed Changes
Test Plan
Pass all unit tests and integration tests.