fix(github-plugin): removes the processed org check to return all the… #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… org repos, and pulls the repository data when adding scope previous behavior would return a single repository. Also no repo data was returned so the user could not add the repo to devlake fixes part of my issue in apache#7655
dosubot
bot
added
size:S
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… org repos, and pulls the repository data when adding scope
previous behavior would return a single repository. Also no repo data was returned so the user could not add the repo to devlake
fixes part of my issue in #7655
pr-type/bug-fix,pr-type/feature-development, etc.Summary
Removees the processed org check which was preventing multiple repositories from being pulled. The processed org check would trigger after a single repo was returned. Also I've added in the repo data model because it wasn't returning data, and therefore data couldn't be added to the scope!
Does this close any open issues?
Partial fix for #7655
Screenshots
Include any relevant screenshots here.
Other Information
I'm not sure what the initial purpose the processedOrgs check had, so deleting it entirely might be aggressive. But since the app connection is scoped to a single org I don't see a direct downside to removing it.