Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify encKey to encryptionSecret and make .env file readonly in… #5365

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Jun 5, 2023

Summary

unify encKey to encryptionSecret and make .env file readonly in codebase

Does this close any open issues?

part of #5235

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@abeizn abeizn marked this pull request as ready for review June 6, 2023 02:58
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remember to update the document

@abeizn abeizn merged commit ff51f3b into apache:main Jun 6, 2023
chenggui53 pushed a commit to chenggui53/incubator-devlake that referenced this pull request Jun 6, 2023
apache#5365)

* feat: unify encKey to encryptionSecret and make .env file readonly in codebase

* fix: e2e test and ci-lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants