Prevent driver from overwhelming during orphan file removal #13084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RussellSpitzer @aokolnychyi @flyrain @szehon-ho @huaxingao @flyrain @anuragmantri when you get a chance |
karuppayya
changed the title
karuppayya
force-pushed
the
remove_tmp
branch
2 times, most recently
from
0c7e4bc to
2c2f66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, orphaned files are collected at the driver before deletion. This can overwhelm the driver when dealing with millions of orphaned files.
This change introduces distributed deletion (with a default parallelism of 10, to avoid throttling), which avoids sending results back to the driver. The operation will return the total count of deleted files.
For backward compatibility, the results will still include the full paths of all orphaned files by default, which can be configured.
TODO