Flink: Dynamic Iceberg Sink: Add dynamic writer and committer #13080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the dynamic version of the writer and committer for the Flink Dynamic Iceberg Sink. Conceptually, they work similar to the IcebergSink, but they support writing to multiple tables. Write results from each table are aggregated from the DynamicWriter in the DynamicWriteResultAggregator, from where they are sent to the DynamicCommitter. Broken out of apache#12424, depends on apache#13032.
mxm
changed the title
pvary
reviewed
May 19, 2025
| import java.util.NavigableMap; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
| import org.apache.iceberg.io.WriteResult; | ||
| import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; | ||
| import org.apache.iceberg.util.ScanTaskUtil; | ||
|
|
||
| class CommitSummary { | ||
| public class CommitSummary { |
There was a problem hiding this comment.
Is this still an @Internal class?
There was a problem hiding this comment.
Are you suggesting to annotate with @Internal because of the visibility change?
pvary
reviewed
May 19, 2025
| @@ -23,7 +23,7 @@ | |||
| import org.apache.iceberg.relocated.com.google.common.base.Preconditions; | |||
| import org.apache.iceberg.relocated.com.google.common.collect.Lists; | |||
|
|
|||
| class DeltaManifests { | |||
| public class DeltaManifests { | |||
pvary
reviewed
May 19, 2025
| @@ -148,6 +170,7 @@ public void initialize(int taskId, int attemptId) { | |||
| OutputFileFactory.builderFor(table, taskId, attemptId) | |||
| .format(format) | |||
| .ioSupplier(() -> tableSupplier.get().io()) | |||
| .defaultSpec(spec) | |||
There was a problem hiding this comment.
Is this a behavioral change in the IcebergSink?
There was a problem hiding this comment.
I don't think so. This field in the builder would normally be set to the current table spec, but for the dynamic sink we can write multiple active specs, for which we will have a dedicated writer each.
pvary
reviewed
May 19, 2025
| } | ||
|
|
||
| @Override | ||
| public byte[] serialize(DynamicCommittable committable) throws IOException { |
pvary
reviewed
May 19, 2025
| view.read(manifestBuf); | ||
| return new DynamicCommittable(key, manifestBuf, jobId, operatorId, checkpointId); | ||
| } | ||
| throw new IOException("Unrecognized version or corrupt state: " + version); |
pvary
reviewed
May 19, 2025
| view.read(manifestBuf); | ||
| return new DynamicCommittable(key, manifestBuf, jobId, operatorId, checkpointId); | ||
| } | ||
| throw new IOException("Unrecognized version or corrupt state: " + version); |
pvary
reviewed
May 19, 2025
| break; | ||
| } | ||
| } | ||
| Long parentSnapshotId = snapshot.parentId(); |
pvary
reviewed
May 19, 2025
| } else { | ||
| commitDeltaTxn(table, branch, pendingResults, summary, newFlinkJobId, operatorId); | ||
| } | ||
| continuousEmptyCheckpoints = 0; |
|
Could you please provide tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dynamic version of the writer and committer for the Flink Dynamic Iceberg Sink. Conceptually, they work similar to the IcebergSink, but they support writing to multiple tables. Write results from each table are aggregated from the DynamicWriter in the DynamicWriteResultAggregator, from where they are sent to the DynamicCommitter.
Broken out of #12424.