feat: add apply in transaction to support stack action #949
Conversation
ZENOTME
force-pushed
the
apply_metadata
branch
from
c20c598 to
536dce7
Compare
|
Hi @liurenjie1024, I think we should resolve this PR first before working on #964. It will affect the interface in transactions. |
ZENOTME
force-pushed
the
apply_metadata
branch
4 times, most recently
from
5e8e0b0 to
9b7ef77
Compare
|
I think this PR is ready to review. cc @Fokko @liurenjie1024 @Xuanwo @sdd |
crates/iceberg/src/transaction.rs
Outdated
| @@ -261,7 +286,7 @@ impl<'a> FastAppendAction<'a> { | |||
| let mut manifest_stream = self | |||
| .snapshot_produce_action | |||
| .tx | |||
| .table | |||
| .current_table | |||
There was a problem hiding this comment.
I realized that there are some functions based on the table. And storing only current metadata may cause inconsistencies easily in the future. So change to store current table instead of metadata
|
I think we should try to move this along. cc @liurenjie1024 @Fokko @sdd |
Thanks, I'll take a look recently. |
There was a problem hiding this comment.
Thanks @ZENOTME for this pr, generally LGTM! Just one minor suggestion.
|
cc @ZENOTME Would you help to resolve the conflicts? |
Sure. |
This PR resolve: #596. I refer the implementation from pyiceberg: https://github.com/apache/iceberg-python/blob/4d648bb834963efba886d62e79fa3e1e26288dd0/pyiceberg/table/__init__.py#L258