Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQL Catalog - Tables #610

Merged
merged 8 commits into from
Oct 12, 2024

Conversation

callum-ryan
Copy link
Contributor

this is a WIP. Pulling tests in from @fqaiser94's original recommended test set as I go.

Signed-off-by: callum-ryan <[email protected]>
@callum-ryan callum-ryan marked this pull request as ready for review September 12, 2024 07:45
Copy link
Collaborator

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @callum-ryan for this great pr! Generally LGTM, I've left some minor points to fix, others are great! One thing I want to ask is that do we have plan for tests against other databases such as postgres, mysql?

crates/catalog/sql/src/catalog.rs Outdated Show resolved Hide resolved
crates/catalog/sql/src/catalog.rs Show resolved Hide resolved
@callum-ryan
Copy link
Contributor Author

Thanks @callum-ryan for this great pr! Generally LGTM, I've left some minor points to fix, others are great! One thing I want to ask is that do we have plan for tests against other databases such as postgres, mysql?

Thanks @liurenjie1024, I have fixed the points raised. I'm happy to take a look at integration tests for PostgreSQL and MySQL, it will take me some extra time as I am unfamiliar with the way these tests run for the repo. The REST catalog tests seem to be doing what I'd need to spin up some containers with the appropriate backends.

Copy link
Collaborator

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @callum-ryan !

@liurenjie1024 liurenjie1024 merged commit ae6d095 into apache:main Oct 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants