[HUDI-8726] Test hollow commit handling for table version 8 #12708
+985
−481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the test utils so it can work in both table version 6 timeline layout 1 and table version 8 and timeline layout 2 mode. Previously as all the metafolder path and the completion instant file names are are hard coded, so they cannot accommodate based on the given version. FileCreateUtilsV2 is introduced which takes metaClient as input to solve this issue. We should use this as opposed to old FileCreateUtilsV2 in the future.
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8726-TODO2
branch
from
a9abe6e to
8915a8e
Compare
Davis-Zhang-Onehouse
changed the title
Test hollow commit handling in both old and new table version and timeline layout version.
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8726-TODO2
branch
from
8915a8e to
6bca2e4
Compare
nsivabalan
reviewed
Jan 26, 2025
| /** | ||
| * Utils for creating dummy Hudi files in testing. | ||
| */ | ||
| public class FileCreateUtilsV2 extends FileCreateUtilsBase { |
There was a problem hiding this comment.
Why V2 create Utils?
for source code, generally V2 makes sense. but for test utils, why do we need V2?
why can't we fix exiting utils class only.
There was a problem hiding this comment.
I tried and after 4 hrs here is what it turns out to be #12712 :)
It requires another 4 hrs looking into individual test failures.
| "BLOCK, SIX, VERSION_1", | ||
| "BLOCK, EIGHT, VERSION_2", | ||
| "USE_TRANSITION_TIME, SIX, VERSION_1", | ||
| "USE_TRANSITION_TIME, EIGHT, VERSION_2" |
There was a problem hiding this comment.
timeline layout versions are tied to table version. 6 is for 1 and 8 is to 2. So, why make 2 args. we could just make args as
HollowCommitHandling handlingMode,
HoodieTableVersion tableVersion
| .setTableName("testTable") | ||
| .setTimelineLayoutVersion(timelineLayoutVersion.getVersion()) | ||
| .setTableVersion(tableVersion) | ||
| .setTableType(HoodieTableType.MERGE_ON_READ).initTable(getDefaultStorageConf(), basePath); |
There was a problem hiding this comment.
can we validate the table version matches after instantiation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
1st commit
Revised the test utils so it can work in both table version 6 timeline
layout 1 and table version 8 and timeline layout 2 mode. Previously as
all the metafolder path and the completion instant file names are are
hard coded, so they cannot accommodate based on the given version.
FileCreateUtilsV2 is introduced which takes metaClient as input to solve
this issue. We should use this as opposed to old FileCreateUtilsV2 in
the future.
2nd commit
Test hollow commit handling in both old and new table version and
timeline layout version.
Impact
better test coverage
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist