-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-8680] Enable partition stats by default #12707
Open
nsivabalan
wants to merge
14
commits into
apache:master
Choose a base branch
from
nsivabalan:enablePSIDefault_rebased
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+856
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:XL
PR with lines of changes > 1000
size:L
PR with lines of changes in (300, 1000]
and removed
size:XL
PR with lines of changes > 1000
labels
Jan 24, 2025
codope
force-pushed
the
enablePSIDefault_rebased
branch
from
January 26, 2025 06:20
f281bf4
to
434cab8
Compare
codope
reviewed
Jan 26, 2025
...di-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
Show resolved
Hide resolved
…kWhenReplaceCommitIsPresent
github-actions
bot
added
size:XL
PR with lines of changes > 1000
and removed
size:L
PR with lines of changes in (300, 1000]
labels
Jan 26, 2025
codope
reviewed
Jan 26, 2025
.../hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestExpressionIndex.scala
Outdated
Show resolved
Hide resolved
codope
reviewed
Jan 26, 2025
.../hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestExpressionIndex.scala
Outdated
Show resolved
Hide resolved
codope
changed the title
[HUDI-8680][DNM] Enable psi default rebased
[HUDI-8680] Enable partition stats by default
Jan 26, 2025
codope
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from #12671 are already addressed.
4 tasks
@hudi-bot run azure |
codope
reviewed
Jan 27, 2025
Comment on lines
+88
to
+92
if (containsAnySqlFunction(queryFilters)) { | ||
// If the query contains any SQL function, skip the pruning. | ||
// Expression Index will be used in such cases, if available. | ||
Option.empty | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main change for fixing PSI pruning tests. No change in else
block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Enabling partition stats by default for the spark engine.
Impact
Enabling partition stats by default for the spark engine.
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist