Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8680] Enable partition stats by default #12707

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nsivabalan
Copy link
Contributor

@nsivabalan nsivabalan commented Jan 24, 2025

Change Logs

Enabling partition stats by default for the spark engine.

Impact

Enabling partition stats by default for the spark engine.

Risk level (write none, low medium or high below)

medium

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added size:XL PR with lines of changes > 1000 size:L PR with lines of changes in (300, 1000] and removed size:XL PR with lines of changes > 1000 labels Jan 24, 2025
@codope codope force-pushed the enablePSIDefault_rebased branch from f281bf4 to 434cab8 Compare January 26, 2025 06:20
@github-actions github-actions bot added size:XL PR with lines of changes > 1000 and removed size:L PR with lines of changes in (300, 1000] labels Jan 26, 2025
@apache apache deleted a comment from hudi-bot Jan 26, 2025
@codope codope changed the title [HUDI-8680][DNM] Enable psi default rebased [HUDI-8680] Enable partition stats by default Jan 26, 2025
Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from #12671 are already addressed.

@apache apache deleted a comment from hudi-bot Jan 26, 2025
@codope
Copy link
Member

codope commented Jan 26, 2025

@hudi-bot run azure

Comment on lines +88 to +92
if (containsAnySqlFunction(queryFilters)) {
// If the query contains any SQL function, skip the pruning.
// Expression Index will be used in such cases, if available.
Option.empty
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change for fixing PSI pruning tests. No change in else block.

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL PR with lines of changes > 1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants