[HUDI-8072] Enable log file only test for Hive MOR tables #12669
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
HUDI-8072
branch
from
a587795 to
dd58c99
Compare
jonvex
approved these changes
Jan 17, 2025
nsivabalan
reviewed
Jan 22, 2025
| try (HoodieTestDataGenerator dataGen = new HoodieTestDataGenerator(0xDEEF)) { | ||
| // One commit; reading one file group containing a base file only | ||
| commitToTable(dataGen.generateInserts("001", 100), INSERT.value(), writeConfigs); | ||
| // One commit: reading one file group containing 1 log file only. |
There was a problem hiding this comment.
I did not review entire test class. but can you confirm we are not giving up on straight forward test case, where 1st commit added a base file right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Enable log file only file slice generation and enable the test.
Impact
Fixed a bug in log file file slice generation for Hive, and enabled the corresponding tests
Risk level (write none, low medium or high below)
Low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist