Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: apache/httpcomponents-core#470
This PR cleans up the test classes. The proposed changes include:
Remove superfluous exceptions in throws clauses
Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code.
Test classes and methods should have default package visibility
It is recommended to use the default package visibility to improve readability:
Fix assertion argument orders
To me it seems like some assertions where not correctly upgraded when JUnit5 was introduced, where the order of arguments for some
Assertions
methods was changed.