Fix HTTPCLIENT-2331: Skip cookie header generation if a Cookie header is present #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is already present This fix ensures that if a Cookie header is already present in the request, HttpClient skips adding additional Cookie headers from the BasicCookieStore.
ok2c
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for HTTPCLIENT-2331: Single Cookie Header for Multiple Cookies
When an explicit Cookie header is added using
setHeader()and multiple cookies exist in theBasicCookieStore,HttpClientwas sending separate Cookie headers for the manually set cookies and the cookies in the store. This fix ensures that if a Cookie header is already present in the request,HttpClientskips adding additional Cookie headers from theBasicCookieStore.This change conforms to the expectation that a single Cookie header should be sent where all cookies are separated by a semicolon, as per RFC6265.