Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exec chain behaviour when automatic retries are enabled. #480

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

cachescrubber
Copy link
Contributor

Document classic and async exec chain behaviour when automatic retries are enabled.

https://issues.apache.org/jira/browse/HTTPCLIENT-2291

@ok2c
Copy link
Member

ok2c commented Aug 31, 2023

@cachescrubber Awesome! One thing, though. Do you mind dropping code snippets out of Javadocs, as code examples often tend to get out of sync with the actual API usage.

@cachescrubber
Copy link
Contributor Author

@ok2c I removed the snippets. Having implemented a handler myself I remember having to dig in the source of clientBuilder in order to find the name of the retry handler. What about

 * @see ChainElement#RETRY
 * @see HttpClientBuilder#addExecInterceptorAfter(String, String, ExecChainHandler)
 * @see HttpClientBuilder#addExecInterceptorBefore(String, String, ExecChainHandler)

I think I would at least document the name (ChainElement#RETRY) in order to place the interceptors relative to it. WDYT?

@ok2c
Copy link
Member

ok2c commented Aug 31, 2023

I think I would at least document the name (ChainElement#RETRY) in order to place the interceptors relative to it. WDYT?

Makes perfect sense.

@ok2c ok2c merged commit 509ba67 into apache:master Aug 31, 2023
9 checks passed
@cachescrubber cachescrubber deleted the handler_retry_behaviour branch August 31, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants