Use for-each

apache · Sep 22, 2024 · 1c0e373 · 1c0e373
1 parent e9560a4
commit 1c0e373
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 16 deletions.
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java b/httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java
@@ -86,8 +86,7 @@ protected void formatMultipartHeader(final MultipartPart part, final OutputStrea
                 writeBytes(FIELD_SEP, out);
                 writeBytes(field.getValue(), out);
                 final List<NameValuePair> parameters = field.getParameters();
-                for (int i = 0; i < parameters.size(); i++) {
-                    final NameValuePair parameter = parameters.get(i);
+                for (final NameValuePair parameter : parameters) {
                     final String name = parameter.getName();
                     final String value = parameter.getValue();
                     writeBytes("; ", out);

diff --git a/...nt5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientProtocolStarter.java b/...nt5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientProtocolStarter.java
@@ -113,17 +113,17 @@ private void logFlowControl(final String prefix, final int streamId, final int d
                         @Override
                         public void onHeaderInput(final HttpConnection connection, final int streamId, final List<? extends Header> headers) {
                             if (HEADER_LOG.isDebugEnabled()) {
-                                for (int i = 0; i < headers.size(); i++) {
-                                    HEADER_LOG.debug("{} << {}", id, headers.get(i));
+                                for (final Header header : headers) {
+                                    HEADER_LOG.debug("{} << {}", id, header);
                                 }
                             }
                         }
 
                         @Override
                         public void onHeaderOutput(final HttpConnection connection, final int streamId, final List<? extends Header> headers) {
                             if (HEADER_LOG.isDebugEnabled()) {
-                                for (int i = 0; i < headers.size(); i++) {
-                                    HEADER_LOG.debug("{} >> {}", id, headers.get(i));
+                                for (final Header header : headers) {
+                                    HEADER_LOG.debug("{} >> {}", id, header);
                                 }
                             }
                         }

diff --git a/...java/org/apache/hc/client5/http/impl/async/HttpAsyncClientProtocolNegotiationStarter.java b/...java/org/apache/hc/client5/http/impl/async/HttpAsyncClientProtocolNegotiationStarter.java
@@ -189,17 +189,17 @@ private void logFlowControl(final String prefix, final int streamId, final int d
                         @Override
                         public void onHeaderInput(final HttpConnection connection, final int streamId, final List<? extends Header> headers) {
                             if (HEADER_LOG.isDebugEnabled()) {
-                                for (int i = 0; i < headers.size(); i++) {
-                                    HEADER_LOG.debug("{} << {}", id, headers.get(i));
+                                for (final Header header : headers) {
+                                    HEADER_LOG.debug("{} << {}", id, header);
                                 }
                             }
                         }
 
                         @Override
                         public void onHeaderOutput(final HttpConnection connection, final int streamId, final List<? extends Header> headers) {
                             if (HEADER_LOG.isDebugEnabled()) {
-                                for (int i = 0; i < headers.size(); i++) {
-                                    HEADER_LOG.debug("{} >> {}", id, headers.get(i));
+                                for (final Header header : headers) {
+                                    HEADER_LOG.debug("{} >> {}", id, header);
                                 }
                             }
                         }

diff --git a/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientCustomContext.java b/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientCustomContext.java
@@ -65,8 +65,8 @@ public static void main(final String[] args) throws Exception {
                 System.out.println("----------------------------------------");
                 System.out.println(httpget + "->" + new StatusLine(response));
                 final List<Cookie> cookies = cookieStore.getCookies();
-                for (int i = 0; i < cookies.size(); i++) {
-                    System.out.println("Local cookie: " + cookies.get(i));
+                for (final Cookie element : cookies) {
+                    System.out.println("Local cookie: " + element);
                 }
                 EntityUtils.consume(response.getEntity());
                 return null;

diff --git a/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientFormLogin.java b/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientFormLogin.java
@@ -60,8 +60,8 @@ public static void main(final String[] args) throws Exception {
                 if (cookies.isEmpty()) {
                     System.out.println("None");
                 } else {
-                    for (int i = 0; i < cookies.size(); i++) {
-                        System.out.println("- " + cookies.get(i));
+                    for (final Cookie element : cookies) {
+                        System.out.println("- " + element);
                     }
                 }
                 return null;
@@ -82,8 +82,8 @@ public static void main(final String[] args) throws Exception {
                 if (cookies.isEmpty()) {
                     System.out.println("None");
                 } else {
-                    for (int i = 0; i < cookies.size(); i++) {
-                        System.out.println("- " + cookies.get(i));
+                    for (final Cookie element : cookies) {
+                        System.out.println("- " + element);
                     }
                 }
                 return null;