-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hop server enhancement #4569 #4574
base: main
Are you sure you want to change the base?
Conversation
6237f6c
to
6a3ce3c
Compare
- add command line options for (host, port, shutdownport, proxyhost, proxyport,ssl) - support for override properties on the command line - add shutdown listener to web server - add shutdown servlet - add RemoteHopServer class to interact with a Hop server and clean HopServerMeta - remove setup hop server syntax by hostname and port - add HopServerTerminate extension point after shutdown - all HopServerXXX extension points now provide a HopServer object, rather than a HopServer/WebServer mix - Set abbreviateSynopsis and usageHelpAutoWidth to command line
we need better option grouping, port appears as sub-option of password, host appears as sub-option of help etc:
|
tested:
|
For option grouping, this is the behavior of Picoli if we do not define a unique letter for an option. |
is this still stuck in draft for an actual reason? @nadment |
No for me PR is ok. It's a lot of changes to test. I haven't found a better solution to group Picoli options |
Alright, then I'll start testing and reviewing this. There are some other minor changes (deprecations) that I will probably include in here. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:check
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.addresses #123
), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.