Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Hop server enhancement #4569

Open
nadment opened this issue Nov 14, 2024 · 0 comments · May be fixed by #4574
Open

[Feature Request]: Hop server enhancement #4569

nadment opened this issue Nov 14, 2024 · 0 comments · May be fixed by #4574
Assignees
@nadment
Labels
Hop Server new feature P3 Nice to have

Comments

@nadment
Copy link
Contributor

nadment commented Nov 14, 2024 •
edited
Loading

What would you like to happen?

The hop-server.bat command has 3 setup modes

  • SETUP BY CONFIG FILE: hop-server.bat hop-server-config.xml
  • SETUP BY SERVER NAME: hop-server.bat -n HOPSERVER01 --gs
  • SETUP BY HOSTNAME AND PORT: hop-server.bat <hostname> <port> <shutdownport> -k -u=<user> -p=<password>

  1. Remove the last mode because it's buggy and doesn't allow the command to indicate which protocol to use: HTTP or HTTPS)

  2. All config parameters must have a command line option, add the following:

--host
--port
--shutdownport
--ssl
--proxyhost
--proxyport

  1. If you are using config file or named server mode, it should be possible to override certain properties on the command line:
    hop-server.bat hop-server-config.xml -gs -u=<user> -p=<password>
    hop-server.bat -n HOPSERVER01 -proxyhost=192.0.0.1 -proxyport=8080

  2. Add command line options --help and --version

  3. Add the command to stop a remote server on a shutdown port requiring authentication.
    hop-server.bat hop-server-config.xml --kill
    hop-server.bat -n HOPSERVER01 -k -shutdowport=8082

  4. Code cleanup

  • Create an org.apache.hop.www.RemoteHopServer class to interact with a Hop server, and thus remove a few of methods from HopServerMeta. HopServerMeta would then become pure metadata.

Issue Priority

Priority: 3

Issue Component

Component: Hop Server
@nadment nadment self-assigned this Nov 14, 2024
@github-actions github-actions bot added the P3 Nice to have label Nov 14, 2024
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
857d4ba 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
b8e504a 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
460c391 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
@nadment nadment linked a pull request Nov 15, 2024 that will close this issue
Hop server enhancement #4569 #4574
Open
5 tasks
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
d1cc6ec 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
6237f6c 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
nadment added a commit to nadment/hop that referenced this issue Nov 15, 2024
@nadment
Hop server enhancement apache#4569
6a3ce3c 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
nadment added a commit to nadment/hop that referenced this issue Nov 20, 2024
@nadment
Hop server enhancement apache#4569
63c0557 
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
- Set abbreviateSynopsis and usageHelpAutoWidth to command line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
Hop Server new feature P3 Nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hop server enhancement #4569 nadment/hop
1 participant
@nadment