HIVE-28059: Iceberg REST Catalog #5606
Open
+2,708
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
# Conflicts: # iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_major_compaction_partition_evolution_w_id_spec_w_filter.q.out
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
nrg4878
requested review from
deniskuzZ,
dengzhhu653,
saihemanth-cloudera,
ayushtkn,
zhangbutao and
szehon-ho
|
dengzhhu653
reviewed
Feb 10, 2025
| catalog.setConf(configuration); | ||
| Map<String, String> properties = new TreeMap<>(); | ||
| if (curi != null) { | ||
| properties.put("uri", curi); |
There was a problem hiding this comment.
the curi should always be empty?
dengzhhu653
reviewed
Feb 10, 2025
| Method method = clazz.getDeclaredMethod(HIVE_METASTORE_CREATE_HANDLER_METHOD, | ||
| Configuration.class); | ||
| String methodName = MetastoreConf.getVar(conf, MetastoreConf.ConfVars.HMS_HANDLER_CREATE); | ||
| Method method = clazz.getDeclaredMethod(methodName,Configuration.class); |
There was a problem hiding this comment.
the newHMSHandler looks enough to create an embedded client, is there any reason to ask for a new method?
dengzhhu653
reviewed
Feb 10, 2025
| @@ -0,0 +1 @@ | |||
| Need to force creation of a directory. | |||
There was a problem hiding this comment.
nit: no data or configuration under the data/conf, can we remove it?
|
Leave some minor comments, rest looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a basic implementation of the Iceberg REST Catalog as a service embedded within HMS.
Why are the changes needed?
For Hive users that have started using Iceberg to store data and want to expose those same tables to external query engines, implementing the Iceberg REST catalog embedded within HMS allows an easy upgrade and deployment path.
Although a dedicated service to host the REST catalog is certainly desirable, it also implies deploying and managing another service.
Does this PR introduce any user-facing change?
It does since HMS then 'hosts' a servlet that implements the Iceberg REST Catalog API.
Is the change a dependency upgrade?
No.
How was this patch tested?
Unit tests.
(Restart of #5145 )