refresh pom structure and enable unit test #673
Conversation
| @@ -28,16 +28,17 @@ under the License. | |||
| <version>2.0.0-SNAPSHOT</version> | |||
| </parent> | |||
|
|
|||
| <groupId>org.apache.griffin</groupId> | |||
There was a problem hiding this comment.
The griffin-bom module is used to manage the version of third-party dependencies. If users want to import griffin-metric to your project, they need to import griffin-bom together by import-bom way, this can help users to manage the version.
but for test or dev purposed dependencies, they should not declared in bom, that means our users will import test dependencies to use griffin, that is not necessary.
these dev or test dependencies, should be managed by griffin-parent in root pom, so all modules can use the same dev env.
dev and test are not user oriented artifacts.
There was a problem hiding this comment.
you mean all dependecies about dev/test purpose should be removed from the pom under bom project. Am I right?
There was a problem hiding this comment.
yes, move test/dev dependencies to root(parent) pom.
There was a problem hiding this comment.
@guoyuepeng , I have refreshed again. please review again
| */ | ||
| @TableId(value="mid", type = IdType.AUTO) | ||
| @TableId(value="vid", type = IdType.AUTO) |
toyboxman
force-pushed
the
griffin-2.0.0-dev
branch
from
d3b2ee9 to
e10339f
Compare
|
could you fix the conflict? |
toyboxman
force-pushed
the
griffin-2.0.0-dev
branch
from
e10339f to
d3b2ee9
Compare
No description provided.