[#6196] feat(iceberg): adjust table distribution if creating table without specifying disribution mode #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
FANNG1
changed the title
FANNG1
force-pushed
the
iceberg_distribution
branch
3 times, most recently
from
ac4876f to
75c9027
Compare
FANNG1
force-pushed
the
iceberg_distribution
branch
from
75c9027 to
b6b71fb
Compare
|
@jerryshao @jerqi PTAL |
FANNG1
added
branch-0.8
yuqi1129
reviewed
Jan 16, 2025
| @@ -588,6 +596,16 @@ public void testConnection( | |||
| } | |||
| } | |||
|
|
|||
| private static Distribution getIcebergDefaultDistribution( | |||
| Boolean isSorted, Boolean isPartitioned) { | |||
| @@ -513,6 +514,13 @@ public Table createTable( | |||
| .build()) | |||
| .toArray(IcebergColumn[]::new); | |||
|
|
|||
| // Gravitino NONE distribution means the client side doesn't specify distribution not the same | |||
There was a problem hiding this comment.
distribution not the -> distribution, which is not the same as none distribution in Iceberg.
jerqi
approved these changes
Jan 16, 2025
| @@ -513,6 +514,13 @@ public Table createTable( | |||
| .build()) | |||
| .toArray(IcebergColumn[]::new); | |||
|
|
|||
| // Gravitino NONE distribution means the client side doesn't specify distribution, which is | |||
There was a problem hiding this comment.
Actually this isn't accurate for me. The unspecified distribution and unpartitioned should be different. But it may change more code. The fix may better than legacy implement. So I approve this.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
…thout specifying disribution mode (#6214) ### What changes were proposed in this pull request? Adjust the distribution mode for creating Iceberg table with none distribution. the following is the Spark adjust logic, the flink is similar. ```java private DistributionMode defaultWriteDistributionMode() { if (table.sortOrder().isSorted()) { return RANGE; } else if (table.spec().isPartitioned()) { return HASH; } else { return NONE; } } ``` ### Why are the changes needed? Fix: #6196 ### Does this PR introduce _any_ user-facing change? Yes, add document ### How was this patch tested? add UT and IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adjust the distribution mode for creating Iceberg table with none distribution. the following is the Spark adjust logic, the flink is similar.
Why are the changes needed?
Fix: #6196
Does this PR introduce any user-facing change?
Yes, add document
How was this patch tested?
add UT and IT