-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5779] feat(iceberg): add OSS support for IcebergRESTService docker image #6096
base: main
Are you sure you want to change the base?
Conversation
Could you add |
98cbe13
to
c72f5cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to update docker-image-details.md
- apache/gravitino-iceberg-rest:0.8.0-incubating
- Supports OSS and ADLS storage.
@FANNG1 Thank you for the suggestion. I have added the GRAVITINO_OSS_ROLE_ARN, and I also tested the oss-token provider on Alibaba Cloud. Below is the process and results:
|
LGTM, Could you also update the docker image document?
update the iceberg rest service document
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one comment. 😄
@@ -60,9 +60,10 @@ docker run --rm -d -p 9001:9001 apache/gravitino-iceberg-rest:0.7.0-incubating | |||
|
|||
Changelog | |||
|
|||
- apache/gravitino-iceberg-rest:0.7.0-incubating | |||
- apache/gravitino-iceberg-rest:0.8.0-incubating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new log, instead of modify 0.7.0 to 0.8.0
What changes were proposed in this pull request?
add OSS support for IcebergRESTService docker image
Why are the changes needed?
Fix: #5779
no
How was this patch tested?
run SQL with access Aliyun OSS data