Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6004] fix: use fullName instead of names.get(0) when get role #6057

Merged
merged 6 commits into from
Jan 7, 2025
+114 −2
Merged

[#6004] fix: use fullName instead of names.get(0) when get role #6057

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edf3a59
[#6004] fix: use fullName instead of names.get(0) when get role
cool9850311 Jan 1, 2025
fea3fe8
move 54-56 before 53 for easier understanding
cool9850311 Jan 1, 2025
49b8254
test: Add Unit Test for RoleMetaService.getInstance().getRoleIdByMeta…
cool9850311 Jan 3, 2025
2959ec6
fix: make insertRelation with role name contains dot won't throw exce…
cool9850311 Jan 3, 2025
627da8e
modify parse method
cool9850311 Jan 6, 2025
60f40d0
test: Add unit tests for role object handling in MetadataObjects
cool9850311 Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/org/apache/gravitino/storage/relational/service/MetadataObjectService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static long getMetadataObjectId(

List<String> names = DOT_SPLITTER.splitToList(fullName);
if (type == MetadataObject.Type.ROLE) {
return RoleMetaService.getInstance().getRoleIdByMetalakeIdAndName(metalakeId, names.get(0));
return RoleMetaService.getInstance().getRoleIdByMetalakeIdAndName(metalakeId, fullName);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move 54-56 before 53 so that this is easier to understand?


long catalogId =
Expand Down