[#5901] feat(core): support tag event to Gravitino server #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenccl
suggested changes
Dec 26, 2024
| @@ -72,7 +85,10 @@ public Tag getTag(String metalake, String name) throws NoSuchTagException { | |||
| // TODO: getTagPreEvent | |||
| try { | |||
| // TODO: getTagEvent | |||
| @@ -121,7 +150,11 @@ public MetadataObject[] listMetadataObjectsForTag(String metalake, String name) | |||
| // TODO: listMetadataObjectsForTagPreEvent | |||
| try { | |||
| // TODO: listMetadataObjectsForTagEvent | |||
|
It would be better to turn this PR into a draft before updating the unit tests. |
TungYuChiang
force-pushed
the
feature/tagEvent
branch
from
aba70be to
42e0f47
Compare
|
will review the PR until #5944 is merged for some duplicated logic, please wait for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #5901
Does this PR introduce any user-facing change?
no
How was this patch tested?