Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5900] feat(tag): support tag pre-event to Gravitino server #5980

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

amazingLychee
Copy link

@amazingLychee amazingLychee commented Dec 25, 2024

What changes were proposed in this pull request?

Implemented pre-event handling for all tag-related operations, including:

  • listTags
  • listTagsInfo
  • getTag
  • createTag
  • alterTag
  • deleteTag
  • listMetadataObjectsForTag
  • listTagsForMetadataObject
  • listTagsInfoForMetadataObject
  • associateTagsForMetadataObject
  • getTagForMetadataObject

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: #5900

Does this PR introduce any user-facing change?

No

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

@xunliu xunliu requested a review from FANNG1 December 25, 2024 03:46
@FANNG1
Copy link
Contributor

FANNG1 commented Dec 25, 2024

there are some duplicate code with #5944, wait until #5944 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Support tag pre event to Gravitino server
2 participants