Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5976] Improvement(bin):Add validation checks to the startup scripts to prevent incorrect usage #5977

Merged
merged 11 commits into from
Jan 15, 2025
+11 −2
Merged

[#5976] Improvement(bin):Add validation checks to the startup scripts to prevent incorrect usage #5977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a5dec5f
[#5976] Improvement(bin):Add validation checks to the startup scripts…
liuchunhao Dec 24, 2024
6b38ae9
[#5976] Improvement(bin): Remove the '.template' file extension from …
liuchunhao Dec 24, 2024
fe87ce5
[#5976] Improvement(bin): Update the error message for startup failur…
liuchunhao Dec 25, 2024
73c7c10
[#5976] Improvement(docs): Update getting-started.md
liuchunhao Jan 7, 2025
dbea2d5
[#5976] Improvement(docs): Update getting-started.md & bin/common.sh
liuchunhao Jan 11, 2025
07f02c6
[#5976] Improvement(docs): Update bin/common.sh
liuchunhao Jan 11, 2025
044f464
[#5976] Improvement(docs): Update getting-started.md
liuchunhao Jan 11, 2025
9499434
[#5976] Improvement(docs): Update getting-started.md
liuchunhao Jan 11, 2025
4cfcd6d
[#5976] Improvement(bin): Update the instruction message in common.sh
liuchunhao Jan 11, 2025
3d6c62f
[#5976] Improvement(bin): Update the instruction message in common.sh
liuchunhao Jan 12, 2025
cb8d850
[#5976] Improvement(bin): rename common.sh to common.sh.template
liuchunhao Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bin/common.sh → bin/common.sh.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ if [[ -f "${GRAVITINO_CONF_DIR}/gravitino-env.sh" ]]; then
. "${GRAVITINO_CONF_DIR}/gravitino-env.sh"
fi

if [[ -z "${GRAVITINO_VERSION}" ]]; then
echo -e "GRAVITINO_VERSION is not set, you may need to:\n" \
"1. Ensure that a compiled version of Gravitino is available at " \
"\${GRAVITINO_HOME}/distribution/package. You may need to compile it first, " \
"if you are installing the software from source code.\n" \
"2. Execute gravitino.sh in the \${GRAVITINO_HOME}/distribution/package/bin directory."
exit 1
fi

GRAVITINO_CLASSPATH+=":${GRAVITINO_CONF_DIR}"

JVM_VERSION=8
Expand Down
0 bin/gravitino-iceberg-rest-server.sh → ...gravitino-iceberg-rest-server.sh.template
View file
Open in desktop
File renamed without changes.
0 bin/gravitino.sh → bin/gravitino.sh.template
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions docs/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ To use Gravitino locally on macOS or Linux, follow these similar steps:

Or, you can install Gravitino from scratch, follow [how-to-build](./how-to-build.md) and [how-to-install](./how-to-install.md).

3. Start Gravitino using the gravitino.sh script:
3. Start Gravitino using the gravitino.sh script in the binary release package or Docker image:

```shell
<path-to-gravitino>/bin/gravitino.sh start
${GRAVITINO_HOME}/bin/gravitino.sh start
```

## Installing Apache Hive on AWS or Google Cloud Platform
Expand Down
Loading